-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2347. Reimplement duties controller.rb and badges controller.rb #39
base: main
Are you sure you want to change the base?
Conversation
You can still host the backend server as an API server where APIs can be tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, it looks like there are a lot of changes required before this work can be merged. I noticed that there doesn't seem to be any testing done (API), and it appears that the guidelines may not have been followed. While I added a few review comments, there are still many other issues in other files that need to be addressed. Please make sure to follow the guidelines and make the appropriate changes.
app/models/badge.rb
Outdated
@@ -0,0 +1,20 @@ | |||
class Badge < ApplicationRecord | |||
|
|||
def self.get_id_from_name(badge_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please help me locate where we have utilized this class method and other methods in this model? I am having difficulty finding its application.
This is only a Backend Change project hence, there is no link for the hosted application. Also, we have done Swagger UI API testing for testing the API endpoints